[Elastic-Agent] Correctly unmarshal Protocol #17843
Merged
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Protocol (https/http) was not correctly unmarshaly and assigned to the value of the struct. Because of this the checking was trying to use a plain text connection or a TLS enabled endpoint. Fixes: elastic#17841
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
@michalpristas Lets make sure all our test in CI for integration only uses TLS. |
|
I can confirm this fixes the issues in cloud. |
ruflin
approved these changes
Apr 21, 2020
ruflin
reviewed
Apr 21, 2020
| @@ -23,6 +23,7 @@ | |||
| - Remove the kbn-version on each request to the Kibana API. {pull}17764[17764] | |||
| - Fixed process spawning on Windows {pull}17751[17751] | |||
| - Fixed injected log path to monitoring beat {pull}17833[17833] | |||
| - Make sure that the Elastic Agent connect over TLS in cloud. {pull}xx[xxx] | |||
There was a problem hiding this comment.
@ph Can you fix this in a follow up?
There was a problem hiding this comment.
🤦 one day we wont need this.
|
Merged this already to get it into the build cycle. |
6 tasks
ph
changed the title
ph
changed the title
ph
added a commit
to ph/beats
that referenced
this pull request
Apr 21, 2020
The Protocol (https/http) was not correctly unmarshaly and assigned to the value of the struct. Because of this the checking was trying to use a plain text connection or a TLS enabled endpoint. Fixes: elastic#17841 (cherry picked from commit 0765f94)
6 tasks
ph
added
v7.8.0
and removed
needs_backport
ph
added a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Protocol (https/http) was not correctly unmarshaly and assigned to
the value of the struct. Because of this the checking was trying to use
a plain text connection or a TLS enabled endpoint.
Fixes: #17841
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs